-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change people functions to synapser #168
Conversation
@anngvu , any ideas on why it would fail to build this package with synapser on mac and windows but work fine on ubuntu? |
@allaway Since I'm mainly Linux, I'm honestly sure what the Mac and Windows issues are -- the logs aren't super helpful -- will need to look more into it. |
@allaway OK, I think this is actually a GH workflow issue. |
* Respecify OS versions for Mac and Windows * Add fallback deps install * Upgrade step version
So testing locally:
So I revised the workflow to use precompiled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a hint of what source table/column usually maps to in the NF context would be nice, but as functionality goes everything works with people_table_id = "syn23564971", people_column = "ownerID", source_table_id = "syn16858331", source_column = "createdBy", both dry_run TRUE and FALSE
, so merging.
This PR introduces synapser to
Imports
and refactors the add_people_from_table and .store_rows functions to use synapser. Modified the .check_login function to look forsyn
object imported by library(synapser).